Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(gha): use official docker/setup-docker-action #2913

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

vvoland
Copy link
Contributor

@vvoland vvoland commented Dec 9, 2024

What does this PR do?

Use our official github action to setup rootless docker

Why is it important?

Related issues

Copy link

netlify bot commented Dec 9, 2024

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 644a1ea
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/67581d7ca6ff12000871dd72
😎 Deploy Preview https://deploy-preview-2913--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@vvoland vvoland changed the title gha: Use official docker/setup-docker-action chore(gha): Use official docker/setup-docker-action Dec 9, 2024
Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland changed the title chore(gha): Use official docker/setup-docker-action chore(gha): use official docker/setup-docker-action Dec 9, 2024
mdelapenya
mdelapenya previously approved these changes Dec 10, 2024
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Looks great using an official image for this, thank you so much 👏

@mdelapenya
Copy link
Member

@vvoland please let me know when this is ready to be merged 🙏

@vvoland vvoland marked this pull request as ready for review December 10, 2024 10:53
@vvoland vvoland requested a review from a team as a code owner December 10, 2024 10:53
@vvoland
Copy link
Contributor Author

vvoland commented Dec 10, 2024

Dropped the last commit that ran the nightly tests on this PR. Should be ready to go now 👍🏻

Copy link
Collaborator

@stevenh stevenh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

image

@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Dec 10, 2024
@mdelapenya mdelapenya self-assigned this Dec 10, 2024
@mdelapenya mdelapenya merged commit 06249a8 into testcontainers:main Dec 10, 2024
124 checks passed
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Dec 10, 2024
* main:
  chore(gha): Use official setup-docker-action (testcontainers#2913)
mdelapenya added a commit to mtellis2/testcontainers-go that referenced this pull request Dec 11, 2024
* main: (234 commits)
  chore(ci): add Github labels based on PR title (testcontainers#2914)
  chore(gha): Use official setup-docker-action (testcontainers#2913)
  chore(ci): enforce conventional commits syntax in PR titles (testcontainers#2911)
  feat(nats): WithConfigFile - pass a configuration file to nats server (testcontainers#2905)
  chore: enable implicit default logger only in testing with -v (testcontainers#2877)
  fix: container binds syntax (testcontainers#2899)
  refactor(cockroachdb): to use request driven options (testcontainers#2883)
  chore(deps): bump actions/setup-go from 5.0.0 to 5.1.0 (testcontainers#2904)
  chore(deps): bump ossf/scorecard-action from 2.3.1 to 2.4.0 (testcontainers#2903)
  chore(deps): bump test-summary/action from 2.3 to 2.4 (testcontainers#2902)
  feat(wait): strategy walk (testcontainers#2895)
  feat(wait): tls strategy (testcontainers#2896)
  docs: better contribution guidelines (testcontainers#2893)
  fix(influxdb): Respect custom waitStrategy (testcontainers#2845)
  fix: only upload to sonar on ubuntu-latest (testcontainers#2891)
  fix: build artifact name properly (testcontainers#2890)
  fix: do not run sonar upload when ryuk is disabled (testcontainers#2889)
  fix: update GH actions for uploading/downloading artifacts (testcontainers#2888)
  feat(ci): Enable master moby with rootless (testcontainers#2880)
  fix(redpanda): temporary file use
  ...
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Dec 13, 2024
* main:
  feat(gcloud)!: add support to seed data when using RunBigQueryContainer (testcontainers#2523)
  security(deps): bump golang.org/x/crypto from 0.28.0 to 0.31.0 (testcontainers#2916)
  chore(ci): add Github labels based on PR title (testcontainers#2914)
  chore(gha): Use official setup-docker-action (testcontainers#2913)
  chore(ci): enforce conventional commits syntax in PR titles (testcontainers#2911)
  feat(nats): WithConfigFile - pass a configuration file to nats server (testcontainers#2905)
  chore: enable implicit default logger only in testing with -v (testcontainers#2877)
  fix: container binds syntax (testcontainers#2899)
  refactor(cockroachdb): to use request driven options (testcontainers#2883)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants