chore: clarify image auth warning message for public images #3228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
stevenh
approved these changes
Jul 3, 2025
Contributor
stevenh
left a comment
stevenh
left a comment
There was a problem hiding this comment.
Nice one have seen this and thought the same on many occasions, thanks for the PR
mdelapenya
approved these changes
Jul 3, 2025
Member
mdelapenya
left a comment
mdelapenya
left a comment
There was a problem hiding this comment.
LGTM, thank you so much for this tiny but important fix!
We have had this around for long time, and now it's fixed, I really appreciate your time here 🙇
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Jul 4, 2025
* main: chore: clarify image auth warning message for public images (testcontainers#3228) chore(deps): bump github.com/go-viper/mapstructure/v2 (testcontainers#3219) chore(deps): bump github/codeql-action from 3.28.16 to 3.29.2 (testcontainers#3222) chore(deps): bump mkdocs-include-markdown-plugin from 7.1.5 to 7.1.6 (testcontainers#3225) deps: update testcontainers/sshd image to 1.3.0 (testcontainers#3220) chore(deps): bump urllib3 from 2.2.2 to 2.5.0 (testcontainers#3214) deps: gopsutil and purego update (testcontainers#3217) docs: document copy from container (testcontainers#3215)
mdelapenya
added a commit
that referenced
this pull request
Jul 31, 2025
…util/v4-4.25.6 * main: fix(dockermcpgateway): use duckduckgo instead of brave (#3247) feat: add Solace pubsub+ module (#3230) feat(options): add WithProvider (#3241) chore(deps): bump github/codeql-action from 3.29.2 to 3.29.3 (#3237) chore(deps): bump golang.org/x/oauth2 in /modules/weaviate (#3240) chore(deps): bump mkdocs-include-markdown-plugin from 7.1.5 to 7.1.6 (#3239) chore(deps): bump requests from 2.32.0 to 2.32.4 (#3204) feat(mcpgateway): add MCP gateway module (#3232) chore(deps): bump golang.org/x/oauth2 in /modules/pulsar (#3236) chore(deps): bump golang.org/x/oauth2 in /modules/gcloud (#3235) chore(deps): bump golang.org/x/oauth2 in /modules/k3s (#3234) chore: prepare for next minor development cycle (0.39.0) chore: use new version (v0.38.0) in modules and examples Update go.mod in azure module (#3231) fix: strip headers from logs using log stream specification (#3226) chore: clarify image auth warning message for public images (#3228) chore(deps): bump github.com/go-viper/mapstructure/v2 (#3219) chore(deps): bump github/codeql-action from 3.28.16 to 3.29.2 (#3222) chore(deps): bump mkdocs-include-markdown-plugin from 7.1.5 to 7.1.6 (#3225)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates the log message shown when Docker image authentication credentials are not found during an image pull.
The new message clarifies that missing credentials is expected for public images and is not a critical error.
No functional or behavioral changes are introduced; only the log output is improved for clarity.
Why is it important?
The previous log message used the word "Failed", which could be interpreted as a critical error by users, even though missing credentials is normal for public images.
This change helps avoid confusion and reduces unnecessary concern for users pulling public images, improving the developer experience and log readability.
Related issues