docs: add docs regarding Colima usage #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddumelendez
reviewed
Oct 4, 2022
mdelapenya
reviewed
Oct 5, 2022
There was a problem hiding this comment.
This PR LGTM, thanks @hhsnopek for your contribution!
Once merged, I'd work in placing both Podman and Colima docs under a System Requirements parent page, like in the Java site: https://www.testcontainers.org/supported_docker_environment/#using-colima
Let's wait for @eddumelendez's comments on #547 (comment) to merge it
Codecov Report
@@ Coverage Diff @@
## main #547 +/- ##
==========================================
- Coverage 68.84% 68.61% -0.24%
==========================================
Files 22 22
Lines 2154 2154
==========================================
- Hits 1483 1478 -5
- Misses 533 537 +4
- Partials 138 139 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mdelapenya
approved these changes
Oct 5, 2022
mdelapenya
added a commit
to prskr/testcontainers-go
that referenced
this pull request
Oct 6, 2022
* main: Log docker server info (testcontainers#548) docs: add docs regarding Colima usage (testcontainers#547)
Closed
mdelapenya
referenced
this pull request
in mdelapenya/testcontainers-go
Dec 21, 2022
* main: Add system requirements parent docs page for podman and colima (#562) Support for cap-add/cap-drop (#555) fix container NetworkMode usage (#560) chore: use hashed versions of test-summary action (#556) chore: use container.State() function in tests (#543) Log docker server info (#548) docs: add docs regarding Colima usage (#547) chore: add emoji to breaking changes in release drafter (#542) chore: add CONTRIBUTING file (#539) issue #537 Rename the wait/multi.go file to wait/all.go (#541) docs: add a basic layout for wait strategies in docs (#536) docs: improve consistency and fix typos (#534) chore: do not skip test (#528) chore: include test flakiness in the release drafter (#535) chore: retire old versions of Go (#530)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This pull request adds documentation around the utilization of Colima with Docker. It includes two ways of integrating with Colima, one of which is suggested by Colima and the other is the workaround defined from a Slack Thread of debugging which also serves as a pre-v0.4.0 Colima solution.
Preview