Support returning all IP addresses of a container

[gauravgahlot]

Fixes #513

[mdelapenya]

I've just left a few suggestions on naming. You know, naming things...

Thanks for your contribution.

[gauravgahlot]

Brings it back to how I originally wrote it. Cool. 👍

[mdelapenya]

BTW, could you add tests for the new method? 🙏

[gauravgahlot]

BTW, could you add tests for the new method? 🙏

Should have added one implicitly. Done.

[gauravgahlot]

As a side note @mdelapenya, I noticed certain lint issues in the code (also verified with golangci-lint). I was thinking may be we should have a make lint target for future. If that works for you, please create an issue and assign it to me.

[mdelapenya]

As a side note @mdelapenya, I noticed certain lint issues in the code (also verified with golangci-lint). I was thinking may be we should have a make lint target for future. If that works for you, please create an issue and assign it to me.

We'd like to evaluate if pre-commit works for us, therefore a check would happen at that level.

[codecov]

Codecov Report

Merging #553 (1bcf925) into main (c0d73a6) will increase coverage by 0.07%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main     #553      +/-   ##
==========================================
+ Coverage   68.99%   69.07%   +0.07%     
==========================================
  Files          22       22              
  Lines        2174     2186      +12     
==========================================
+ Hits         1500     1510      +10     
- Misses        535      537       +2     
  Partials      139      139              

Impacted Files	Coverage Δ
container.go	80.72% <ø> (ø)
docker.go	71.77% <75.00%> (+0.14%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[gauravgahlot]

@mdelapenya Is anything required from my end for this PR to be merged?

[mdelapenya]

Thanks for your contribution @gauravgahlot !