chore: proper messaging on disabling ryuk #566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
added
documentation
mdelapenya
requested review from
bsideup,
eddumelendez,
HofmeisterAn and
kiview
Codecov Report
@@ Coverage Diff @@
## main #566 +/- ##
==========================================
- Coverage 69.30% 69.02% -0.28%
==========================================
Files 22 22
Lines 2186 2202 +16
==========================================
+ Hits 1515 1520 +5
- Misses 534 543 +9
- Partials 137 139 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
eddumelendez
approved these changes
Oct 13, 2022
kiview
approved these changes
Oct 14, 2022
mdelapenya
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It does :
Why is it important?
In the light of #561, good conversations have appeared around disabling Ryuk. For that reason, we are improving the docs and the outcomes of disabling Ryuk at the container request.