Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check if the container request is for the reaper #574

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

mdelapenya
Copy link
Member

@mdelapenya mdelapenya commented Oct 21, 2022

What does this PR do?

It checks if the container request of the current container is for a reaper before creating a reaper for the container.

Therefore, the banner for the reaper must not be displayed.

Why is it important?

When a reaper is created, it always skips the reaper for itself, so we must check if the request is for a reaper, and this is achieved comparing the reaper image and the image of the request

Related issues

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #574 (f77643f) into main (322aa4e) will decrease coverage by 17.43%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##             main     #574       +/-   ##
===========================================
- Coverage   32.84%   15.40%   -17.44%     
===========================================
  Files          13       13               
  Lines        1757     1759        +2     
===========================================
- Hits          577      271      -306     
- Misses       1092     1442      +350     
+ Partials       88       46       -42     
Impacted Files Coverage Δ
docker.go 20.33% <75.00%> (-18.14%) ⬇️
reaper.go 3.50% <0.00%> (-74.57%) ⬇️
mounts.go 0.00% <0.00%> (-50.00%) ⬇️
logger.go 50.00% <0.00%> (-37.50%) ⬇️
docker_mounts.go 9.75% <0.00%> (-36.59%) ⬇️
container.go 40.96% <0.00%> (-6.03%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@mdelapenya mdelapenya merged commit 786954c into testcontainers:main Oct 21, 2022
@mdelapenya mdelapenya deleted the fix-reaper branch October 21, 2022 21:57
@mdelapenya mdelapenya changed the title fix: check if the container request if for the reaper fix: check if the container request is for the reaper Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants