Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update gotest.md - fix errors in the example #623

Merged
merged 1 commit into from
Nov 15, 2022
Merged

update gotest.md - fix errors in the example #623

merged 1 commit into from
Nov 15, 2022

Conversation

pantafive
Copy link
Contributor

What does this PR do?

Fixes errors in the example codeю

Why is it important?

The example code is not working as expected.

How to test this PR

Just run the example code.

@pantafive pantafive marked this pull request as ready for review November 15, 2022 17:23
@pantafive pantafive requested a review from a team as a code owner November 15, 2022 17:23
@mdelapenya mdelapenya self-assigned this Nov 15, 2022
@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Nov 15, 2022
mdelapenya
mdelapenya approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdelapenya
Copy link
Member

Thanks for this small but valuable contribution to our docs!

Just to let you know we are in the process of extracting the code snippets directly from the tests which will enforce they are truly executed in the CI

@mdelapenya mdelapenya merged commit f72dfee into testcontainers:main Nov 15, 2022
@pantafive
Copy link
Contributor Author

pantafive commented Nov 16, 2022 •
edited
Loading

@mdelapenya , Thank you, you are doing a great job!

mdelapenya referenced this pull request in mdelapenya/testcontainers-go Nov 17, 2022
@mdelapenya
Merge branch 'main' into examples-work
bc0ec00 
* main:
  docs: update method to `nginxC.Terminate` (#627)
  fix: do not prepend garbage in the container.Exec response (#624)
  chore: retire podman pipeline (#625)
  update gotest.md - fix errors in the example (#623)
  chore: sync governance files (#622)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

Assignees

@mdelapenya mdelapenya

Labels
documentation Docs, docs, docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pantafive @mdelapenya