Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add mysql example #700

Merged
merged 5 commits into from
Dec 17, 2022
Merged

chore: add mysql example #700

merged 5 commits into from
Dec 17, 2022

Conversation

mdelapenya
Copy link
Member

  • chore: bootstrap mysql example module
  • chore: add test for mysql example module
  • chore: remove dependency with mysql, delegating it to the example module

What does this PR do?

Using the example generator, it adds an example module for MySQL, moving the specific-to-mysql tests from the core module to the example one.

Why is it important?

Two important things:

  1. adds a new example on MySQL
  2. removes the dependency with MySQL libraries, moving them to the example module. This is important as we do not distribute the dependency as part of the library

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner December 17, 2022 08:49
@mdelapenya mdelapenya added dependencies Dependencies or external services documentation Docs, docs, docs. labels Dec 17, 2022
@mdelapenya mdelapenya self-assigned this Dec 17, 2022
@mdelapenya mdelapenya merged commit bb03057 into testcontainers:main Dec 17, 2022
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Dec 17, 2022
@mdelapenya
Merge branch 'main' into remove-redis-dependency
bd7c703 
* main:
  chore: add mysql example (testcontainers#700)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Dec 19, 2022
@mdelapenya
Merge branch 'main' into compose-module
5cd80f2 
* main:
  chore: reduce concurrent builds (testcontainers#702)
  chore: add mysql example (testcontainers#700)
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Dec 21, 2022
@mdelapenya
Merge branch 'main' into bump-transitive-deps-security-concerns
10ddbd5 
* main: (79 commits)
  chore: reduce concurrent builds (testcontainers#702)
  chore: add mysql example (testcontainers#700)
  chore(deps): bump google.golang.org/api from 0.104.0 to 0.105.0 (testcontainers#699)
  chore(deps): bump google.golang.org/api in /examples/firestore (testcontainers#683)
  chore(deps): bump cloud.google.com/go/spanner in /examples/spanner (testcontainers#688)
  chore(deps): bump google.golang.org/api in /examples/pubsub (testcontainers#685)
  chore(deps): bump google.golang.org/api in /examples/spanner (testcontainers#684)
  chore(deps): bump google.golang.org/grpc in /examples/firestore (testcontainers#686)
  chore(deps): bump google.golang.org/api in /examples/bigtable (testcontainers#680)
  chore(deps): bump google.golang.org/api in /examples/datastore (testcontainers#678)
  chore(deps): bump golang.org/x/text from 0.3.7 to 0.5.0 (testcontainers#660)
  chore(deps): bump github.com/magiconair/properties from 1.8.6 to 1.8.7 (testcontainers#677)
  chore: postgres example (testcontainers#674)
  Add bigtable example (testcontainers#676)
  chore(deps): bump github.com/containerd/containerd from 1.6.10 to 1.6.12 (testcontainers#675)
  chore: run go mod tidy in examples (testcontainers#672)
  Improve datastore, firestore, pubsub and spanner tests (testcontainers#670)
  chore: group dependabot updates (testcontainers#668)
  chore: update mkdocs format to go-yaml v3 (testcontainers#667)
  chore: generate dependabot configs for examples (testcontainers#654)
  ...
mdelapenya added a commit to slsyy/testcontainers-go that referenced this pull request Dec 21, 2022
@mdelapenya
Merge branch 'main' into follow_logs
bcdcbd8 
* main: (335 commits)
  chore: reduce concurrent builds (testcontainers#702)
  chore: add mysql example (testcontainers#700)
  chore(deps): bump google.golang.org/api from 0.104.0 to 0.105.0 (testcontainers#699)
  chore(deps): bump google.golang.org/api in /examples/firestore (testcontainers#683)
  chore(deps): bump cloud.google.com/go/spanner in /examples/spanner (testcontainers#688)
  chore(deps): bump google.golang.org/api in /examples/pubsub (testcontainers#685)
  chore(deps): bump google.golang.org/api in /examples/spanner (testcontainers#684)
  chore(deps): bump google.golang.org/grpc in /examples/firestore (testcontainers#686)
  chore(deps): bump google.golang.org/api in /examples/bigtable (testcontainers#680)
  chore(deps): bump google.golang.org/api in /examples/datastore (testcontainers#678)
  chore(deps): bump golang.org/x/text from 0.3.7 to 0.5.0 (testcontainers#660)
  chore(deps): bump github.com/magiconair/properties from 1.8.6 to 1.8.7 (testcontainers#677)
  chore: postgres example (testcontainers#674)
  Add bigtable example (testcontainers#676)
  chore(deps): bump github.com/containerd/containerd from 1.6.10 to 1.6.12 (testcontainers#675)
  chore: run go mod tidy in examples (testcontainers#672)
  Improve datastore, firestore, pubsub and spanner tests (testcontainers#670)
  chore: group dependabot updates (testcontainers#668)
  chore: update mkdocs format to go-yaml v3 (testcontainers#667)
  chore: generate dependabot configs for examples (testcontainers#654)
  ...
@mdelapenya mdelapenya mentioned this pull request Dec 23, 2022
Closed
48 tasks
@mdelapenya mdelapenya deleted the mysql-example branch December 25, 2022 22:53
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Jan 4, 2023
@mdelapenya
Merge branch 'main' into pre-creation-hook
3cbf64e 
* main: (44 commits)
  feat: support passing registry credentials to the reaper (testcontainers#647)
  fix: close response body in http strategy (testcontainers#718)
  chore: move e2e module to postgres example module (testcontainers#717)
  chore: bump containerd transitive dep in examples (testcontainers#715)
  chore(deps): bump github.com/containerd/containerd from 1.6.12 to 1.6.14 (testcontainers#703)
  chore(deps): bump github.com/compose-spec/compose-go in /modules/compose (testcontainers#710)
  chore: bump testcontainers-go to 0.17.0 in examples (testcontainers#714)
  chore(deps): bump github.com/docker/compose/v2 in /modules/compose (testcontainers#711)
  chore: support running MySQL compose in ARM (testcontainers#712)
  chore: simplify compose replace directives (testcontainers#713)
  chore: add compose module to dependabot (testcontainers#709)
  chore: move compose code to a separate module (testcontainers#650)
  docs: refine onboarding process with quickstart guide (testcontainers#706)
  chore: move redis-specific tests to the example module (testcontainers#701)
  chore: bump transitive dependencies (#527)
  chore: reduce concurrent builds (testcontainers#702)
  chore: add mysql example (testcontainers#700)
  chore(deps): bump google.golang.org/api from 0.104.0 to 0.105.0 (testcontainers#699)
  chore(deps): bump google.golang.org/api in /examples/firestore (testcontainers#683)
  chore(deps): bump cloud.google.com/go/spanner in /examples/spanner (testcontainers#688)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mdelapenya mdelapenya

Labels
dependencies Dependencies or external services documentation Docs, docs, docs.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mdelapenya