Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify mongodb test #726

Merged
merged 1 commit into from
Jan 4, 2023

Conversation

ravilushqa
Copy link
Contributor

What does this PR do?

cleaner example of using mongo test

Why is it important?

Related issues

@ravilushqa ravilushqa requested a review from a team as a code owner January 4, 2023 18:20
@netlify
Copy link

netlify bot commented Jan 4, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 96f387c
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/63b5c37de3aa10000a54540c
😎 Deploy Preview https://deploy-preview-726--testcontainers-go.netlify.app/examples/mongodb
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ravilushqa
Copy link
Contributor Author

I'm just started investigating your library, and I've found that code from my previous PR could be a cleaner 😄

@dh-ravilushqa
Copy link

also can you please release new version so I will be able to use it 🙏

Copy link
Member

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdelapenya
Copy link
Member

also can you please release new version so I will be able to use it 🙏

Because the example modules are not exported modules, you can simply copy&paste the module code in your own project, so no need to release it

@mdelapenya mdelapenya added the documentation Docs, docs, docs. label Jan 4, 2023
@mdelapenya mdelapenya self-assigned this Jan 4, 2023
@mdelapenya mdelapenya merged commit 5c5c0d1 into testcontainers:main Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants