Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use right import package for compose in docs #791

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

mdelapenya
Copy link
Member

What does this PR do?

It fixes the import paths for the compose module in the documentation

Why is it important?

It was using the root package as import path, which was correct before moving compose to its own package. This PR fixes it

Related issues

@mdelapenya mdelapenya requested a review from a team as a code owner January 26, 2023 18:46
@mdelapenya mdelapenya added bug An issue with the library documentation Docs, docs, docs. labels Jan 26, 2023
@mdelapenya mdelapenya self-assigned this Jan 26, 2023
@netlify
Copy link

netlify bot commented Jan 26, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 4f0ccbc
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/63d2ca852b8653000867884f
😎 Deploy Preview https://deploy-preview-791--testcontainers-go.netlify.app/features/docker_compose
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mdelapenya mdelapenya merged commit e70824e into testcontainers:main Jan 26, 2023
@mdelapenya mdelapenya deleted the fix-docs-compose branch January 27, 2023 00:03
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Feb 10, 2023
* main:
  chore: update Docker labels for containers (testcontainers#813)
  fix: nil pointer dereference in HealthStrategy (testcontainers#802)
  fix: Synchronise writes to containers map (testcontainers#812)
  chore(deps): bump google.golang.org/api from 0.108.0 to 0.109.0 in /examples (testcontainers#810)
  chore(deps): bump cloud.google.com/go/spanner in /examples/spanner (testcontainers#806)
  chore: restructure Docker helper methods (testcontainers#799)
  Verify Reaper state to create new or return existing instance (testcontainers#782)
  docs: add intel as user (testcontainers#798)
  chore: bump containerd in examples (testcontainers#797)
  chore(deps): bump github.com/containerd/containerd from 1.6.15 to 1.6.16 (testcontainers#793)
  chore: extract docker host calculation to an internal package (testcontainers#796)
  chore: run "go mod tidy" automatically when creating examples (testcontainers#794)
  chore: build images with backoff retries (testcontainers#792)
  fix: use right import package for compose in docs (testcontainers#791)
  chore(deps): bump google.golang.org/grpc from 1.52.1 to 1.52.3 in /examples (testcontainers#790)
  Add devcontainer file (testcontainers#765)
  chore: check dependabot dependencies weekly (testcontainers#789)
  chore(deps): bump google.golang.org/grpc from 1.52.0 to 1.52.1 in /examples (testcontainers#783)
  chore: support for titles in examples (testcontainers#775)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue with the library documentation Docs, docs, docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant