feat: convert pulsar example into a Go module #872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdelapenya
added
the
feature
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
mdelapenya
commented
Mar 6, 2023
mdelapenya
commented
Mar 6, 2023
* main: chore: update module dependencies (testcontainers#911) chore: sync governance files (testcontainers#909) chore(deps): bump google.golang.org/api from 0.110.0 to 0.111.0 in /examples (testcontainers#908) chore(deps): bump github.com/aws/aws-sdk-go deps in localstack module (testcontainers#907) chore(deps): bump github.com/jackc/pgx/v4 in /examples/cockroachdb (testcontainers#895) chore(deps): bump github.com/containerd/containerd from 1.6.18 to 1.6.19 (testcontainers#897) chore(deps): bump github.com/compose-spec/compose-go in /modules/compose (testcontainers#899)
|
Kudos, SonarCloud Quality Gate passed!
|
|
@eddumelendez I'm merging this PR as is. We can iterate in the new module in the upcoming releases |
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Mar 7, 2023
* main: chore: go mod tidy modules (testcontainers#920) chore(deps): bump dependencies (testcontainers#919) feat: convert pulsar example into a Go module (testcontainers#872) chore: update module dependencies (testcontainers#911)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR converts the existing Pulsar example into a Go module, and for that:
The public API has been more or less extracted from the existing java module.
Why is it important?
Continue working on having more Go modules for technologies that widely used.
Related issues
How to test this PR
All the tests should pass.