chore: simplify env vars for localstack module #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Kudos, SonarCloud Quality Gate passed!
|
eddumelendez
approved these changes
Feb 22, 2023
mdelapenya
added a commit
to mdelapenya/testcontainers-go
that referenced
this pull request
Feb 23, 2023
* main: chore(deps): bump github.com/compose-spec/compose-go from 1.9.0 to 1.11.0 in /modules/compose (testcontainers#865) chore(deps): bump github.com/docker deps from 23.0.0+incompatible to 23.0.1+incompatible (testcontainers#875) chore(deps): bump github.com/aws/aws-sdk-go libs in /modules/localstack (testcontainers#874) chore: simplify env vars for localstack module (testcontainers#873) chore: remove replace directive in modules (testcontainers#871) chore: bump testcontainers-go in Go modules (testcontainers#870)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It removes the usage of AWS_ env vars for the localstack module, as they are deprecated in the upstream project.
Why is it important?
KISS
Related issues