Fix stop services in docker compose #918
Conversation
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
We are going to merge #910 very soon, which could cause a merge conflict with this one. Will ping you here once that PR is merged, so you can update it 🙏 (or I can do it myself if they are not that severe) |
|
I saw that PR. And I could deal with conflict after that merged. |
|
#910 was merged, no merge conflicts :) |
modules/compose/compose_api_test.go
Outdated
| @@ -101,6 +102,42 @@ func TestDockerComposeAPIWithRunServices(t *testing.T) { | |||
| assert.Contains(t, serviceNames, "nginx") | |||
| } | |||
|
|
|||
| func TestDockerComposeAPIWithStopServices(t *testing.T) { | |||
| compose, err := NewDockerComposeWith( | |||
| WithStackFiles("./testresources/docker-compose-complex.yml"), | |||
There was a problem hiding this comment.
Could you use filepath to build an OS-agnostic path?
There was a problem hiding this comment.
There is also a constant for the yaml file
There was a problem hiding this comment.
Done. And I rebase onto the latest main branch.
sko00o
force-pushed
the
compose-stop-services
branch
from
3e443dc
to
a26b25c
Compare
|
SonarCloud Quality Gate failed.
|
There was a problem hiding this comment.
LGTM!
Thanks @sko00o for your contribution. Even though sonarcloud complains on the duplicated code, I'm going to merge it as, for me, in tests, some duplication comes with readability.
I'd like to thank you for your dedication to testcontainers-go! 🚀
What does this PR do?
Why is it important?
I need to restart services in some test cases.
Related issues