Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use right paths in the release script #928

Merged
merged 2 commits into from
Mar 8, 2023

Conversation

mdelapenya
Copy link
Collaborator

What does this PR do?

This PR fixes the release script:

  • it now handles the next version in go modules properly, as it was replacing too many things, such as the replace directive in the Go modules
  • it uses the right path to each module when replacing the current version

Why is it important?

Make the script as autonomous as possible

It was replacing too many things, such as the replace directive in the Go modules
@mdelapenya mdelapenya requested a review from a team as a code owner March 8, 2023 11:06
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Mar 8, 2023
@mdelapenya mdelapenya self-assigned this Mar 8, 2023
@netlify
Copy link

netlify bot commented Mar 8, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit cab9647
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64086c437521aa0008f72f4b
😎 Deploy Preview https://deploy-preview-928--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@mdelapenya
Copy link
Collaborator Author

Merging as it does not affect the CI

@mdelapenya mdelapenya merged commit 843b27e into testcontainers:main Mar 8, 2023
@mdelapenya mdelapenya deleted the fix-release-script branch March 8, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant