Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: prepare Go modules for the next release #929

Merged

Conversation

mdelapenya
Copy link
Collaborator

What does this PR do?

This PR prepares the Go modules to the next v0.19.0 release. And for that:

  • we added support for skipping git/curl operations in the release script. This is necessary to support modifying the mod files, only.
  • actually update the mod files for next release

For the skip git/curl support, the script now accepts a COMMIT environment variable, taking false as default value. If set to true, any git/curl operation will be indeed performed. At the same time, the DRY_RUN variable controls the script, so if any of them are set (DRY_RUN=true OR COMMIT=false) then the operation won't take effect.

Therefore, performing a release needs:

  • pass DRY_RUN=false explicitly.
  • pass COMMIT=true, explicitly.

In the case we want to prepare a release, which means updating the Go modules to use the new release:

  • pass DRY_RUN=false COMMIT=false, which will modify the files but not commiting them nor pushing the git tags for each module. In consequence, the Go proxy is not invoked with curl. The module files will be updated with the next release, and have to be manually committed and submitted to the repository as part of a PR before producing the release.

Why is it important?

Have consistent dependencies in the Go modules, which need to depend on the new version at the moment the release is created.

@mdelapenya mdelapenya requested a review from a team as a code owner March 8, 2023 12:29
@mdelapenya mdelapenya added chore Changes that do not impact the existing functionality dependencies Dependencies or external services labels Mar 8, 2023
@mdelapenya mdelapenya self-assigned this Mar 8, 2023
@netlify
Copy link

netlify bot commented Mar 8, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit 03b0ccb
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/64087fadab02bc000819e363
😎 Deploy Preview https://deploy-preview-929--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Mar 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mdelapenya mdelapenya merged commit 2f49f6e into testcontainers:main Mar 8, 2023
@mdelapenya mdelapenya deleted the bump-modules-to-new-release branch March 8, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality dependencies Dependencies or external services
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant