Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: skip CI builds when updating the docs #996

Merged
merged 2 commits into from
Mar 28, 2023

Conversation

mdelapenya
Copy link
Member

What does this PR do?

This PR adds a filter when listening to push/pull_request events on the GH workflows, to ignore the events when the changeset includes only files in those paths.

Why is it important?

With the raise of modules and the ability to run in multiple versions, we are seeing hundreds of GH actions being executed under the testcontainers GH org... and there are limits that we are hitting everyday (20 concurrent jobs) specially when dependabot wants to play with us.

With this change we expect to mitigate that issue, and only run the CI jobs with tests for code, not for docs (they are already rendered by Netlify)

@mdelapenya mdelapenya requested a review from a team as a code owner March 28, 2023 12:36
@mdelapenya mdelapenya added the chore Changes that do not impact the existing functionality label Mar 28, 2023
@mdelapenya mdelapenya self-assigned this Mar 28, 2023
@netlify
Copy link

netlify bot commented Mar 28, 2023

Deploy Preview for testcontainers-go ready!

Name Link
🔨 Latest commit bc72515
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-go/deploys/6422ece21a09bc0008e3a35a
😎 Deploy Preview https://deploy-preview-996--testcontainers-go.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Mar 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mdelapenya mdelapenya merged commit 31286e5 into testcontainers:main Mar 28, 2023
mdelapenya added a commit to mdelapenya/testcontainers-go that referenced this pull request Mar 28, 2023
* main:
  chore: skip CI builds when updating the docs (testcontainers#996)
  chore: render logos from the base location (testcontainers#995)
  chore: include how to install the module in the generated docs (testcontainers#991)
@mdelapenya mdelapenya deleted the skip-tests-on-markdown branch March 28, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Changes that do not impact the existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant