Skip to content

Commit

Permalink
fix comments
Browse files Browse the repository at this point in the history
  • Loading branch information
lizhou1111 committed Jul 4, 2024
1 parent b54976c commit 7f71364
Show file tree
Hide file tree
Showing 6 changed files with 16 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ public class TimeplusContainer extends JdbcDatabaseContainer<TimeplusContainer>
public static final String NAME = "timeplus";

private static final DockerImageName DEFAULT_IMAGE_NAME = DockerImageName.parse(
"ghcr.io/timeplus-io/proton:latest"
"timeplus/timeplusd:2.2.10"
);

private static final DockerImageName TIMEPLUS_IMAGE_NAME = DockerImageName.parse(
"ghcr.io/timeplus-io/proton:latest"
"timeplus/timeplusd:2.3.3"
);

@Deprecated
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ public class TimeplusContainer extends JdbcDatabaseContainer<TimeplusContainer>
private static final String NAME = "timeplus";

private static final DockerImageName TIMEPLUS_IMAGE_NAME = DockerImageName.parse(
"ghcr.io/timeplus-io/proton:latest"
"timeplus/timeplusd:2.3.3"
);

private static final Integer HTTP_PORT = 3128;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
package org.testcontainers;

import org.testcontainers.utility.DockerImageName;

public interface TimeplusImages {
DockerImageName TIMEPLUS_PROTON_IMAGE = DockerImageName.parse("timeplus/timeplusd:2.2.10");
DockerImageName TIMEPLUS_IMAGE = DockerImageName.parse("timeplus/timeplusd:2.3.3");
}

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
import org.junit.Test;
import org.junit.runner.RunWith;
import org.junit.runners.Parameterized;
import org.testcontainers.TimeplusTestImages;
import org.testcontainers.TimeplusImages;
import org.testcontainers.containers.TimeplusContainer;
import org.testcontainers.db.AbstractContainerDatabaseTest;
import org.testcontainers.utility.DockerImageName;
Expand All @@ -25,8 +25,8 @@ public SimpleTimeplusTest(DockerImageName imageName) {
@Parameterized.Parameters(name = "{0}")
public static Object[][] data() {
return new Object[][] { //
{ TimeplusTestImages.TIMEPLUS_PROTON_IMAGE },
{ TimeplusTestImages.TIMEPLUS_IMAGE },
{ TimeplusImages.TIMEPLUS_PROTON_IMAGE },
{ TimeplusImages.TIMEPLUS_IMAGE },
};
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ public class TimeplusContainerTest extends AbstractContainerDatabaseTest {

@Test
public void testSimple() throws SQLException {
try (TimeplusContainer timeplus = new TimeplusContainer("ghcr.io/timeplus-io/proton:latest")) {
try (TimeplusContainer timeplus = new TimeplusContainer("timeplus/timeplusd:2.3.3")) {
timeplus.start();

ResultSet resultSet = performQuery(timeplus, "SELECT 1");
Expand All @@ -25,7 +25,7 @@ public void testSimple() throws SQLException {
@Test
public void customCredentialsWithUrlParams() throws SQLException {
try (
TimeplusContainer timeplus = new TimeplusContainer("ghcr.io/timeplus-io/proton:latest")
TimeplusContainer timeplus = new TimeplusContainer("timeplus/timeplusd:2.3.3")
.withUsername("test")
.withPassword("test")
.withDatabaseName("test")
Expand Down

0 comments on commit 7f71364

Please sign in to comment.