Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get region from env variables or default #3556

Merged
merged 6 commits into from
Jun 2, 2022
Merged

Get region from env variables or default #3556

merged 6 commits into from
Jun 2, 2022

Conversation

adrianpozueco
Copy link
Contributor

No description provided.

@adrianpozueco adrianpozueco mentioned this pull request Dec 4, 2020
Closed
rnorth
rnorth reviewed Mar 13, 2021
View reviewed changes
Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you - I think this looks fine. Did you intend to add a documentation update, though? It looks like you've started to prepare for that. If you could add to the localstack module docs it would be perfect - thanks!

@adrianpozueco
Copy link
Contributor Author

adrianpozueco commented Mar 17, 2021 •
edited
Loading

IMHO it’s already documented on:

Environment variables listed in Localstack's README may be used to customize Localstack's configuration. Use the .withEnv(key, value) method on LocalStackContainer to apply configuration settings.

Do you want me to add a sample with Region?

@driverpt
Copy link

Any updates on this ?

@adrianpozueco adrianpozueco requested a review from rnorth June 7, 2021 11:30
@eddumelendez eddumelendez requested a review from a team as a code owner June 1, 2022 20:59
@bsideup bsideup added this to the next milestone Jun 2, 2022
@eddumelendez eddumelendez merged commit 6985636 into testcontainers:master Jun 2, 2022
@eddumelendez
Copy link
Member

eddumelendez commented Jun 2, 2022 •
edited by bsideup
Loading

@adrianpozueco thanks for the contribution! this will be available in next Testcontainers release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcvitaly vcvitaly vcvitaly left review comments

@eddumelendez eddumelendez eddumelendez approved these changes

@bsideup bsideup bsideup approved these changes

@kiview kiview Awaiting requested review from kiview

@rnorth rnorth Awaiting requested review from rnorth

Assignees
No one assigned
Labels
modules/localstack type/enhancement
Projects
None yet
Milestone
1.17.3
Development

Successfully merging this pull request may close these issues.
6 participants
@adrianpozueco @driverpt @eddumelendez @rnorth @bsideup @vcvitaly