Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RecordingFileFactory with default implementation #507

Merged
merged 7 commits into from
Dec 9, 2017
Merged

Add RecordingFileFactory with default implementation #507

merged 7 commits into from
Dec 9, 2017

Commits on Nov 27, 2017

  1. Add RecordingFileFactory with default implementation 

    By default this returns a file in the given vlc recording directory named '<RESULT>-<TestClassName>-<testMethodName>-<YYYYMMdd-HHmmss>.flv', where RESULT is either 'PASSED' or 'FAILED'.

A custom factory can be provided to BrowserWebDriverContainer#withRecordingFileFactory.

The factory is only applicable if the BrowserWebDriverContainer#recordingMode enables the retention of recordings.

Fixes testcontainers#500.
    @ldeck
    ldeck committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    b08541e View commit details
    Browse the repository at this point in the history

  2. Fix Codacy failures/warnings 

    Fixes testcontainers#500
    @ldeck
    ldeck committed Nov 27, 2017
    Configuration menu
    Copy the full SHA
    30dcbb7 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2017

  1. Code review requested changes 

    Fixes testcontainers#500.
    @ldeck
    ldeck committed Dec 6, 2017
    Configuration menu
    Copy the full SHA
    0798524 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2017

  1. Avoiding nano-second risk of test failures due to datetime format dif… 

    …ferences.

Fixes testcontainers#500.
    @ldeck
    ldeck committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    4462951 View commit details
    Browse the repository at this point in the history

  2. Add changelog for custom file name factory 

    Fixes testcontainers#500.
    @ldeck
    ldeck committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    b42082f View commit details
    Browse the repository at this point in the history

  3. Add docs for BrowserWebDriverContainer#withRecordingFileFactory 

    Fixes testcontainers#500.
    @ldeck
    ldeck committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    bb28bed View commit details
    Browse the repository at this point in the history

  4. Update docs for BrowserWebDriverContainer#withRecordingFileFactory 

    Fixes testcontainers#500.
    @ldeck
    ldeck committed Dec 9, 2017
    Configuration menu
    Copy the full SHA
    e014048 View commit details
    Browse the repository at this point in the history