Don't delete images if deleteOnExit is false
#5391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddumelendez
approved these changes
May 23, 2022
bsideup
reviewed
May 23, 2022
core/src/test/java/org/testcontainers/images/builder/ImageFromDockerfileTest.java
Show resolved
Hide resolved
bsideup
approved these changes
May 23, 2022
core/src/test/java/org/testcontainers/images/builder/ImageFromDockerfileTest.java
Outdated
Show resolved
Hide resolved
…DockerfileTest.java Co-authored-by: Eddú Meléndez Gonzales <eddu.melendez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems we had a regression in
ImageFromDockerfile(maybe already since #2809?), which meant that images built by TC were removed by Ryuk, even ifdeleteOnExitwas set tofalse.This PR removes the now superfluous call to
registerImageForCleanup()and instead adds the Ryuk cleanup marker labels only ifdeleteOnExitis set totrue.