Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't ignore sql test query exception, add it as cause exception #5484

Merged
merged 2 commits into from
Jun 13, 2022
Merged

Don't ignore sql test query exception, add it as cause exception #5484

merged 2 commits into from
Jun 13, 2022

Conversation

anatoly0karyakin
Copy link
Contributor

No description provided.

@anatoly0karyakin anatoly0karyakin requested a review from a team as a code owner June 11, 2022 13:58
@anatoly0karyakin
Copy link
Contributor Author

provided
If test running with info logging level real sql exception is hidden. In my case it was "ORA-01882: timezone region not found". So "Container is started, but cannot be accessed by (JDBC URL: %s), please check container logs" is misleading in my case. Additional configuration was required on a client side. From my point of view having real sql exception can be helpful for solving issues.

kiview
kiview approved these changes Jun 13, 2022
View reviewed changes
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A very useful addition, thanks @anatoly0karyakin.

@kiview kiview added this to the next milestone Jun 13, 2022
@kiview kiview merged commit e7cdfa3 into testcontainers:master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kiview kiview kiview approved these changes

@bsideup bsideup bsideup approved these changes

Assignees
No one assigned
Labels
type/enhancement
Projects
None yet
Milestone
1.17.3
Development

Successfully merging this pull request may close these issues.
3 participants
@anatoly0karyakin @bsideup @kiview