Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template with more specific wording #7751

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Update PR template with more specific wording #7751

merged 1 commit into from
Nov 2, 2023

Conversation

gvenzl
Copy link
Contributor

@gvenzl gvenzl commented Nov 2, 2023

This PR just adds some more explicit wording for new module contributions into the PR template. As a newcomer, I found the current wording at first a bit confusing, it was clear once I understood which files were meant.

This PR should help other newcomers to not run into any confusion and be more productive.

Signed-off-by: gvenzl <gerald.venzl@gmail.com>
@gvenzl gvenzl requested a review from a team as a code owner November 2, 2023 03:36
@eddumelendez eddumelendez added this to the next milestone Nov 2, 2023
@eddumelendez eddumelendez merged commit b596ae4 into testcontainers:main Nov 2, 2023
8 checks passed
@eddumelendez
Copy link
Member

Thanks for your feedback and contribution, @gvenzl !

@gvenzl
Copy link
Contributor Author

gvenzl commented Nov 2, 2023

You are very welcome!

@gvenzl gvenzl deleted the PR-text-update branch November 2, 2023 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants