-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-8558 Make Ryuk shutdown hook configurable. #8732
Conversation
Any progress on this issue? |
Any update? |
Any progress on this issue? |
Why is this PR still in the freezer after nearly 3 months? Has any feedback been provided as to why the proposed change has not yet been approved? Are there any concerns on the part of the reviewers that we could work through? The way I read it, this change is purely about adding a configurable option to testcontainers configuration such that we can bypass an early termination of the containers and Spring Application Context beans that use those services can coalesce gracefully. Why is this so controversial? |
@eddumelendez Could you please take a look please? |
Any updates? Is there a way to move forwards with this change? |
Please see my considerations in this comment in the original issue, which explains why we don't just merge this change, although it would allow for a workaround: |
We have decided to revert the change and it will be part of the next release. |
Description
#7717 added the Ryuk shutdown hook. Unfortunately, this leads to some issues e.g. with spring-boot like #8558.
With this PR I want to make the initial feature configurable.