Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve GitLab docs #8775

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Improve GitLab docs #8775

merged 2 commits into from
Aug 21, 2024

Conversation

JapuDCret
Copy link
Contributor

Small documentation update, which caused me a headache, because I forgot, that devices not relying on Docker Desktop won't be able to resolve host.docker.internal.

See also https://stackoverflow.com/questions/48546124/what-is-the-linux-equivalent-of-host-docker-internal for a discussion on that topic

@JapuDCret JapuDCret requested a review from a team as a code owner June 12, 2024 14:10
@avk458
Copy link

avk458 commented Aug 6, 2024

You just save my life

@eddumelendez eddumelendez added this to the next milestone Aug 21, 2024
@eddumelendez eddumelendez changed the title docs: Clarify Gitlab CI Linux setup Improve GitLab docs Aug 21, 2024
@eddumelendez eddumelendez merged commit a85d57a into testcontainers:main Aug 21, 2024
7 of 8 checks passed
@eddumelendez
Copy link
Member

Thanks for your contribution, @JapuDCret! Sorry for the delay. I made some changes for the clarification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants