Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module): support databend #9148

Merged
merged 22 commits into from
Sep 17, 2024

Conversation

hantmac
Copy link
Contributor

@hantmac hantmac commented Aug 26, 2024

Hi there, I am a developer from Databend, which is built in Rust, is an open-source cloud data warehouse that serves as a cost-effective warehouse.

This pr add the New Modules: databend

@hantmac hantmac requested a review from a team as a code owner August 26, 2024 07:27
@hantmac hantmac force-pushed the feat/support-databend branch from 6d20aee to 9e16e8a Compare August 26, 2024 09:47
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hantmac, thanks for your contribution. I have left few comments and please make sure to add modules/databases/databend.md here.

@hantmac hantmac force-pushed the feat/support-databend branch from cb00c66 to 7340f7a Compare August 28, 2024 02:26
@hantmac hantmac requested a review from eddumelendez August 28, 2024 02:31
Copy link
Member

@eddumelendez eddumelendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @hantmac, the project doesn't compile. Can you please take a look at the comments I left? Also, look at this one too

@hantmac hantmac force-pushed the feat/support-databend branch from 47869ba to f4b94c2 Compare August 30, 2024 03:07
@hantmac hantmac force-pushed the feat/support-databend branch from a16da98 to 5a1e600 Compare August 30, 2024 03:21
@eddumelendez
Copy link
Member

@hantmac
Copy link
Contributor Author

hantmac commented Sep 4, 2024

Hi @hantmac, the project doesn't compile. PTAL, https://github.com/testcontainers/testcontainers-java/actions/runs/10626268429/job/29586004747?pr=9148#step:5:24

Thank you very much! I fixed it and have a try again.

@eddumelendez
Copy link
Member

still failing, see https://github.com/testcontainers/testcontainers-java/actions/runs/10693866752/job/29645246728?pr=9148

@hantmac can you make sure the project compiles locally?

@hantmac
Copy link
Contributor Author

hantmac commented Sep 4, 2024

still failing, see https://github.com/testcontainers/testcontainers-java/actions/runs/10693866752/job/29645246728?pr=9148

@hantmac can you make sure the project compiles locally?

Yeah, it's strange I build it successfully using IDEA.
image

But the code has problems actually.

@hantmac hantmac requested a review from eddumelendez September 9, 2024 05:05
@eddumelendez
Copy link
Member

Hi @hantmac, can you please execute ./gradlew spotlessApply

@hantmac
Copy link
Contributor Author

hantmac commented Sep 12, 2024

Hi @hantmac, can you please execute ./gradlew spotlessApply

@eddumelendez Hi bro, I have execute ./gradlew :databend:spotlessApply.

@hantmac
Copy link
Contributor Author

hantmac commented Sep 15, 2024

@eddumelendez Hi bro, if there has no review comments to be resolved, would you like to merge it?

@eddumelendez eddumelendez merged commit bd0b75f into testcontainers:main Sep 17, 2024
103 checks passed
@eddumelendez
Copy link
Member

Thanks for your contribution, @hantmac! I have removed the withDatabaseName because there is no env var to allow creating a new database different than default using env vars.

@eddumelendez eddumelendez added this to the next milestone Sep 17, 2024
@hantmac
Copy link
Contributor Author

hantmac commented Sep 18, 2024

Thanks for your contribution, @hantmac! I have removed the withDatabaseName because there is no env var to allow creating a new database different than default using env vars.

@eddumelendez Thanks for your help!

fokion pushed a commit to fokion/testcontainers-java that referenced this pull request Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants