Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the docker compose delegate with the specified image from the properties #9256

Closed

Conversation

fokion
Copy link
Contributor

@fokion fokion commented Sep 21, 2024

In the #9222 a user is specifying a property with the field name compose.container.image and the ComposeContainer when it creates the composeDelegate variable is always picking the 24.0.2 version of docker. The change that I am proposing is to use the TestcontainersConfiguration in order to parse the property compose.container.image if it exists otherwise continue as it was in the past.

@toomanybyt3s
Copy link

Any updates on this fix, seems like an oversight if all the other images are configurable via the properties file and docker:24.0.2 is hardcoded.

There's a security risk even having such an old version configured even if its a temporary environment

@fokion fokion force-pushed the feat/update-compose-container branch from dbb2c8c to c3ee1e0 Compare October 1, 2024 18:08
@eddumelendez
Copy link
Member

Hi, thanks for your contribution! What I've been thinking is that ComposeContainer should also support DockerImageName and String to declare the image via the constructor as a first argument, similar to the rest of the implementations. Of course, existing constructor should be deprecated.

WDYT @kiview ?

@eddumelendez
Copy link
Member

Closing this as this is not the approach we would like to take. Please see #9222 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants