Initial C++ library #54
Draft
+691
−244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add rudimentary Nix shell flake
Language and grammar
seffradev
force-pushed
the
cpp-abstraction
branch
from
81c3d26 to
c4ec32e
Compare
Collaborator
|
@seffradev it would be great if you could merge it with main |
| tc_container_terminate(request_id); | ||
| } | ||
|
|
||
| std::expected<void, std::string> run() { |
There was a problem hiding this comment.
New to this repo but just thought I'd take a look at what this API may look like as I want to consume the library from C++.
Am I right in thinking the use of std::expected here in this header which a user is expected to include, means that the library is only usable from C++23 and above?
If so I think it may be worth reconsidering, many projects including my one are still on C++20 or C++17.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It implements an initial C++ adapter library design.
It depends on #53.
Why is it important?
It provides idiomatic C++, utilizing RAII patterns.
Related issues