Remove path from default registry #433
Conversation
cristianrgreco
added
bug
| @@ -9,7 +9,7 @@ import { RegistryAuthLocator } from "./registry-auth-locator"; | |||
| import { log } from "../logger"; | |||
| import { AuthConfig } from "../docker/types"; | |||
|
|
|||
| const DEFAULT_REGISTRY = "https://index.docker.io/v1/"; | |||
| const DEFAULT_REGISTRY = "https://index.docker.io"; | |||
There was a problem hiding this comment.
I think https://index.docker.io/v1/ is correct. That's what Docker Desktop resolves too, see:
- DockerImageNotFoundException to pull images testcontainers-dotnet#666 (comment)
- Read
indexServerAddressfrom Docker's/infotestcontainers-java#5347
What I meant by my comment in Slack is, that the GitLab example uses https://index.docker.io as key, but our default key is https://index.docker.io/v1/. Might be addressed due to key.includes(registry).
There was a problem hiding this comment.
@HofmeisterAn Understood, and I found that for the credential provider it didn't work in this case. We check the substring when listing the credentials, but when we go to get the credential we lookup the original registry, which isn't found
|
Kudos, SonarCloud Quality Gate passed!
|
cristianrgreco
added
enhancement
|
Superseded by #484 |
No description provided.