Skip to content

fix: use connection mode override function in config #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 2, 2025
Merged

fix: use connection mode override function in config #775

merged 3 commits into from
Apr 2, 2025

Conversation

alexanderankin
Copy link
Member

fix #774

@CarliJoy
Copy link
Contributor

Well I guess that was my mistake, sorry. LGTM

@alexanderankin alexanderankin force-pushed the fix_connection_mode_override_environment_variable_not_honored branch from e4a4cc6 to 62253f3 Compare April 2, 2025 16:14
santi
santi approved these changes Apr 2, 2025
View reviewed changes
Copy link
Collaborator

@santi santi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alexanderankin alexanderankin merged commit ab2a1ab into main Apr 2, 2025
8 checks passed
@alexanderankin alexanderankin deleted the fix_connection_mode_override_environment_variable_not_honored branch April 2, 2025 18:34
@github-actions github-actions bot mentioned this pull request Apr 2, 2025
Merged
alexanderankin pushed a commit that referenced this pull request Jun 16, 2025
@github-actions
chore(main): release testcontainers 4.11.0 (#800)
632e5f4 
🤖 I have created a release *beep* *boop*
---


##
[4.11.0](testcontainers-v4.10.0...testcontainers-v4.11.0)
(2025-06-15)


### Features

* **core:** Protocol support for container port bind and expose
([#690](#690))
([a0d4317](a0d4317))
* DockerContainer initializer to accept its private members as kwargs
([#809](#809))
([e7feb53](e7feb53))


### Bug Fixes

* **compose:** use provided docker command instead of default
([#785](#785))
([0ae704a](0ae704a))
* **core:** Add kwargs to image build
([#708](#708))
([cc02f94](cc02f94))
* **core:** change with_command type to include list of strings
([#789](#789))
([f7c29cb](f7c29cb))
* **core:** Determine docker socket for rootless docker
([#779](#779))
([6817582](6817582))
* **core:** Typing in docker_client
([#702](#702))
([e8bf224](e8bf224))
* **core:** Typing in generic + network
([#700](#700))
([2061912](2061912))
* **core:** Typing in version
([#701](#701))
([9dc2a02](9dc2a02))
* **core:** wait in test core registry
([#812](#812))
([b574c0e](b574c0e))
* **modules:** fix cosmosdb failure
([#827](#827))
([dafcbed](dafcbed))
* **modules:** update chroma version
([#826](#826))
([b7d41dd](b7d41dd))
* **rabbitmq:** correct pika pypi reference
([#817](#817))
([e90d308](e90d308))
* **registry:** module typed
([#811](#811))
([6b11268](6b11268))
* use connection mode override function in config
([#775](#775))
([ab2a1ab](ab2a1ab)),
closes
[#774](#774)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@santi santi santi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Connection mode override environment variable is not honored
3 participants
@alexanderankin @CarliJoy @santi