Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mssql)!: make EULA acception explicit #218

Merged
merged 8 commits into from
Sep 25, 2024
Merged

fix(mssql)!: make EULA acception explicit #218

merged 8 commits into from
Sep 25, 2024

Conversation

DDtKey
Copy link
Contributor

@DDtKey DDtKey commented Sep 25, 2024 •
edited
Loading

  • EULA: I've noticed the default, while it's necessary to do explicitly. Separate method has been added (might be explicit
  • Make default password publicly available

@DDtKey DDtKey changed the title fix(mssql_server): make accept EULA explicit and stabilize tests fix(mssql_server)!: make accept EULA explicit and stabilize tests Sep 25, 2024
@DDtKey DDtKey changed the title fix(mssql_server)!: make accept EULA explicit and stabilize tests fix(mssql)!: update version and make acception of EULA explicit Sep 25, 2024
@DDtKey DDtKey changed the title fix(mssql)!: update version and make acception of EULA explicit fix(mssql)!: make EULA acception explicit Sep 25, 2024
@DDtKey DDtKey marked this pull request as ready for review September 25, 2024 17:12
@DDtKey DDtKey merged commit 1c29a89 into main Sep 25, 2024
4 of 6 checks passed
This was referenced Sep 25, 2024
Closed
Merged
DDtKey pushed a commit that referenced this pull request Sep 25, 2024
@github-actions
chore: release v0.11.0 (#221)
2646eeb 
## 🤖 New release
* `testcontainers-modules`: 0.10.0 -> 0.11.0 (⚠️ API breaking changes)

### ⚠️ `testcontainers-modules` breaking changes

```
--- failure unit_struct_changed_kind: unit struct changed kind ---

Description:
A public unit struct has been changed to a normal (curly-braces) struct, which cannot be constructed using the same struct literal syntax.
        ref: rust-lang/cargo#10871
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/unit_struct_changed_kind.ron

Failed in:
  struct DynamoDb in /tmp/.tmpSZARLK/testcontainers-rs-modules-community/src/dynamodb_local/mod.rs:8
  struct KwokCluster in /tmp/.tmpSZARLK/testcontainers-rs-modules-community/src/kwok/mod.rs:36
  struct CncfDistribution in /tmp/.tmpSZARLK/testcontainers-rs-modules-community/src/cncf_distribution/mod.rs:30
  struct Redis in /tmp/.tmpSZARLK/testcontainers-rs-modules-community/src/redis/standalone.rs:37
  struct RabbitMq in /tmp/.tmpSZARLK/testcontainers-rs-modules-community/src/rabbitmq/mod.rs:33
  struct ElasticMq in /tmp/.tmpSZARLK/testcontainers-rs-modules-community/src/elasticmq/mod.rs:7
  struct VictoriaMetrics in /tmp/.tmpSZARLK/testcontainers-rs-modules-community/src/victoria_metrics/mod.rs:36
  struct RedisStack in /tmp/.tmpSZARLK/testcontainers-rs-modules-community/src/redis/stack.rs:35
```

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.11.0] - 2024-09-25

### Bug Fixes

- Update version to fix crashes in CI
([#219](#219))
- [**breaking**] Make EULA acception explicit
([#218](#218))

### Documentation

- Add docs for the ganachecli module
([#190](#190))

### Features

- Add ability to enable properties-config for testcontainers
- [**breaking**] Update testcontainers to `0.23.0`
([#216](#216))

### Miscellaneous Tasks

- Update redis requirement from 0.26.0 to 0.27.2
([#211](#211))
- Exclude all-features test run
([#174](#174))
- Update async-nats requirement from 0.35.0 to 0.36.0
([#206](#206))

### Refactor

- [**breaking**] Require the builder pattern for module initalisation
([#161](#161))

### Testing

- Correct password usage

<!-- generated by git-cliff -->
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@CommanderStorm CommanderStorm mentioned this pull request Sep 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@DDtKey