Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
refactor: replace dirs crate with etcetera (#736)
I recently learned that [`dirs`](https://crates.io/crates/dirs) depends on [`option-ext`](https://crates.io/crates/option-ext) via [`dir-sys`](https://crates.io/crates/dirs-sys) (as of `dir-sys` 0.4.1 that came in as part of `dirs` 5.0.1), which is MPL 2.0 licensed. [It does not appear that the author is interested reconsidering their stance on licensing](dirs-dev/dirs-sys-rs#21 (comment)), which unfortunately creates some complications for projects under the CNCF umbrella (as well as many corporate projects), and so I thought I would propose switching `dirs` out for `etcetera` since it is MIT or Apache 2.0 licensed. As you can see from the linked thread, this is a fairly common limitation for adoption, so in the interest of enabling further adoption, I believe it would be in the best interest for `testcontainers-rs` to reconsider this dependency, especially considering how trivial it is to replace 🙂 FWIW, I have done testing on my end to ensure that the changes I'm proposing produce similar results under Mac OS and Linux, but since I don't have direct access to Windows I can't say with 100% certainty that they do though from reading through the code across both libraries, I feel fairly confident that they should. Signed-off-by: Joonas Bergius <joonas@bergi.us>
- Loading branch information