Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: add container startup timeout with default of 1 minute #643

Merged
merged 1 commit into from
May 26, 2024

Commits on May 26, 2024

  1. feat!: add container startup timeout with default of 1 minute

    Closes #247
    
    - Sets default startup timeout to 1 minute
    - Allows to override with `RunnableImage::with_startup_timeout`
    
    Note: breaking change because of default timeout
    
    For now, ENV variable to configure global timeout isn't introduced. First of all, that's quote similar to other languages, (e.g [Go](https://golang.testcontainers.org/features/wait/introduction/#startup-timeout-and-poll-interval), [Java](https://java.testcontainers.org/features/startup_and_waits/))
    
    Another question is which one should take precedence: ENV over `with_startup_timeout` or vice versa?
    
    We can extend it later in compatible way, so not that important at the moment.
    DDtKey committed May 26, 2024
    Configuration menu
    Copy the full SHA
    2a736e1 View commit details
    Browse the repository at this point in the history