refactor!: get rid of associated type ImageArgs and rename to cmd
#649
Commits on Jun 10, 2024
-
refactor!: get rid of associated type for
ImageArgs- really common pattern is to use `Vec<String>` - `args` isn't the best term, because in fact it's Docker's [CMD](https://docs.docker.com/reference/dockerfile/#cmd) - it was not aligned with existing `ExecCommand` - current interface is confusing and users struggle with it - essentially it should be closer to the current representation of environment variables and other parameters - new implementation allows to override args regardless of underlying type - it's still will be possible to use custom strict arguments type for particular image which can be converted to list of strings if users want Dependent PR to modules: testcontainers/testcontainers-rs-modules-community#143
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.