fix!: drop Clone impl for ContainerRequest
#680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`Image` can be cloned just fine, but `ContainerRequest` is not intended to be, and is not, a truly safe structure for cloning. It allows to override: container name, port mappings and log consumers (soon). If necessary, you can always use a reusable constructor/method to create multiple similar `ContainerRequests`.
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Jul 7, 2024
Closed
Merged
DDtKey
pushed a commit
that referenced
this pull request
Jul 7, 2024
## 🤖 New release * `testcontainers`: 0.19.0 -> 0.20.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.20.0] - 2024-07-07 ### Details #### Bug Fixes - [❗] Drop `Clone` impl for `ContainerRequest` ([#680](#680)) - Exclude image pulling time from startup timeout ([#687](#687)) - Waiting for mutiple messages from the same log frame ([#688](#688)) - Pass correct log-source for `stderr` wait strategy ([#692](#692)) #### Features - Introduce log consumers ([#681](#681)) - Introduce `LoggingConsumer` based on `log` crate ([#682](#682)) - [❗] Enhance `LogWaitStrategy` to wait for message appearance multiple times ([#683](#683)) - [❗] Introduce `ExitWaitStrategy` ([#684](#684)) #### Miscellaneous Tasks - Get rid of outdated variables naming ([#679](#679)) - Relax log level for log producer error ([#685](#685)) - Re-configure blocking runtime ([#690](#690)) #### Performance - Avoid spawning log producer without consumers ([#689](#689)) #### Refactor - Internal log processing structures ([#678](#678)) #### Styling - Apply clippy suggestion ([#693](#693)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imagecan be cloned just fine, butContainerRequestis not intended to be, and is not, a truly safe structure for cloning. It allows to override unique container properties: container name, port mappings and log consumers (soon).If necessary, you can always use a reusable constructor/method to create multiple similar
ContainerRequests.