fix: don't assume docker host is a url #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testcontainers-rust ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
blaenk
commented
Jul 28, 2024
|
Thank you for the contribution and well-described issue! 🚀 I will add windows runner into test-suite (matrix in CI) separately, preferably before merging this |
|
Could you apply Overall, looks like LGTM 🙏 |
|
Done! Thanks for reviewing. |
DDtKey
approved these changes
Jul 29, 2024
Merged
DDtKey
pushed a commit
that referenced
this pull request
Jul 30, 2024
## 🤖 New release * `testcontainers`: 0.20.1 -> 0.21.0 <details><summary><i><b>Changelog</b></i></summary><p> <blockquote> ## [0.21.0] - 2024-07-30 ### Details #### Bug Fixes - Don't assume docker host is a url ([#709](#709)) #### Miscellaneous Tasks - Bump the bollard group across 1 directory with 2 updates ([#710](#710)) #### Refactor - [❗] Put `reqwest` behind `http_wait` feature ([#705](#705)) </blockquote> </p></details> --- This PR was generated with [release-plz](https://github.com/MarcoIeni/release-plz/). Closes #711 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one way to fix #708
Although we still parse into a
Url, we don't pass that value on to clients, sinceUrlmay mutate the input, which in the case of #708, breaks WindowsNamedPipeConnector, which is the default way of connecting to the Docker daemon.I also disabled the SCTP tests on Windows since it doesn't seem there's support for that on Windows.