Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo in an error variant #738

Merged
merged 2 commits into from
Sep 25, 2024
Merged

fix: typo in an error variant #738

merged 2 commits into from
Sep 25, 2024

Conversation

DDtKey
Copy link
Collaborator

@DDtKey DDtKey commented Sep 25, 2024

No description provided.

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for testcontainers-rust ready!

Name Link
🔨 Latest commit b12ba35
🔍 Latest deploy log https://app.netlify.com/sites/testcontainers-rust/deploys/66f3e87691ab570008271058
😎 Deploy Preview https://deploy-preview-738--testcontainers-rust.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DDtKey DDtKey enabled auto-merge (squash) September 25, 2024 10:39
@DDtKey DDtKey merged commit c47a2a9 into main Sep 25, 2024
13 checks passed
@DDtKey DDtKey deleted the fix/typo branch September 25, 2024 10:53
@github-actions github-actions bot mentioned this pull request Sep 25, 2024
DDtKey pushed a commit that referenced this pull request Sep 25, 2024
## 🤖 New release
* `testcontainers`: 0.22.0 -> 0.23.0 (⚠️ API breaking changes)

### ⚠️ `testcontainers` breaking changes

```
--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/enum_variant_added.ron

Failed in:
  variant ClientError:UploadToContainerError in /tmp/.tmpnaUdoG/testcontainers-rs/testcontainers/src/core/client.rs:92
  variant ClientError:CopyToContainerError in /tmp/.tmpnaUdoG/testcontainers-rs/testcontainers/src/core/client.rs:94

--- failure trait_method_added: pub trait method added ---

Description:
A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.35.0/src/lints/trait_method_added.ron

Failed in:
  trait method testcontainers::core::ImageExt::with_copy_to in file /tmp/.tmpnaUdoG/testcontainers-rs/testcontainers/src/core/image/image_ext.rs:62
  trait method testcontainers::ImageExt::with_copy_to in file /tmp/.tmpnaUdoG/testcontainers-rs/testcontainers/src/core/image/image_ext.rs:62
```

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

## [0.23.0] - 2024-09-25

### Details
#### Bug Fixes
- Expose public `copy` types
([#734](#734))
- Typo in an error variant
([#738](#738))

#### Features
- Support copy files to container
([#730](#730))
- Support copying directories to container
([#735](#735))

#### Miscellaneous Tasks
- Copy-to-container interface improvements
([#732](#732))

#### Refactor
- Replace dirs crate with etcetera
([#736](#736))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/MarcoIeni/release-plz/).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant