This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
Protect against nil source in offline_asset_paths #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
searls
added a commit
that referenced
this pull request
Aug 21, 2014
Protect against nil source in offline_asset_paths
|
Landed in 0.10.2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The monkey-patched offline asset path stuff was receiving a nil 'source' argument in our app and crashing before writing the assets and runner.html. It seems prudent to just ignore these. (This PR fixes the problem for us).
FWIW the line in our code that seemed to be triggering this was this:
I think in this case self.checkout_image is nil.