This repository was archived by the owner on Jan 10, 2024. It is now read-only.
fix failed count in ConsoleReporter when there are skipped_or_pending_specs #150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
searls
added a commit
that referenced
this pull request
Dec 11, 2014
…-with-filter fix failed count in ConsoleReporter when there are skipped_or_pending_specs
|
Thanks! |
|
Landed in 0.10.4 |
|
This fix causes wrong failed count if skipped or pending specs are present. Reverting this fix solves the problem. Even with the reverted fix I am not able to reproduce the problem leading to this fix. |
|
@larsklevan can you please try to work with @dgrawunder to understand what went wrong? |
|
I tested this again with a clean sandbox and it looks like my patch is incorrect. I must have overridden something in my environment that was causing it to break. My apologies for not testing it better - please revert the patch. |
searls
added a commit
that referenced
this pull request
Dec 18, 2014
revert PR #150 - was causing incorrect failed count when pending or skipped specs are present
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
failuresoutput in ConsoleReporter is incorrect ifskipped_or_pending_specsis greater than 0.Running:
Before:
After:
Verified that it works if you run the whole test suite and if there is a failure.