Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suture.create :after_old and :after_new hooks #40

Closed
searls opened this issue Aug 22, 2016 · 0 comments
Closed

Suture.create :after_old and :after_new hooks #40

searls opened this issue Aug 22, 2016 · 0 comments
Milestone
Staging mode

Comments

@searls
Copy link
Member

searls commented Aug 22, 2016 •
edited
Loading

When :runs_both is enabled, it may be necessary to clean up state between the old & new code paths to ensure both can run correctly, or—since the new path's result is going to be returned—the old path's side effects cleaned up after the fact

Since any harmful side effects by the old or new code paths will apply to each mode, it may as well be supported by all of our modes as simply after_old and after_new.
@searls searls added this to the Staging mode milestone Aug 22, 2016
This was referenced Aug 22, 2016
Closed
Closed
@searls searls changed the title Suture.create :runs_both_clean_after :runs_both_clean_between Suture.create :after_old and :after_new hooks Aug 28, 2016
@searls searls mentioned this issue Aug 28, 2016
Closed
@searls searls closed this as completed in 0f604ab Aug 28, 2016
searls added a commit that referenced this issue Aug 28, 2016
@searls
Implements the staging :call_both feature.
f037c15 
Fixes #41
Fixes #40
Fixes #46
Fixes #39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Staging mode
Development

No branches or pull requests
1 participant
@searls