Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ok/abstracting business logic #114

Merged
merged 43 commits into from
Jan 17, 2024
Merged

Ok/abstracting business logic #114

merged 43 commits into from
Jan 17, 2024

Conversation

dacoaster
Copy link
Collaborator

No description provided.

isntlazy added 30 commits December 7, 2023 16:43
@isntlazy
added temporary mock for rest api, created required services includin…
4f96701 
…g abstract StorageService and refactoring App.vue to use them
@isntlazy
refactored getConfig, getCredentials, loggedInServices moved to computed
b09abcc
@isntlazy
added mock to gitignore
8af311e
@isntlazy
Remove db-rest-mock.json from tracking
55c3cdc
@isntlazy
moving config to the store level, creating one source of truth for it…
5d08813 
… to avoid multiple requests
@isntlazy
refactoring, continue with the support of new structure step-by-step
8778d50
@isntlazy
started MainView refactoring
9c12f32
@isntlazy
refactoring and debugging
a1f324d
@isntlazy
refactoring, fixing store problem with saving, Main view now started …
d087367 
…rendering in a web app
@isntlazy
refactoring, moving electron-specific actions to the electronService.…
74790a5 
…js, adding browser-specific logic in MenuPopover.vue
@isntlazy
refactoring and moving logic to storage service for CheckTaskWrapper.…
04be48e 
…vue and NotesWrapper.vue, removing unused props
@isntlazy
moving TimelineWrapper electron logic to services
bae725a
@isntlazy
refactored config and credentials for ControlPanel
43f9711
@isntlazy
moving some parts to the store, refactoring Control Panel, removing u…
3a0f4e5 
…nused electron parts
@isntlazy
ControlPanel.vue refactored, moved all electron logic to services
04b2e0f
@isntlazy
refactoring, fixed presession and postsession logic, fixed state id p…
8587f18 
…roblem on initial app load
@isntlazy
refactored, investigated and fixed problem with summary dialog
fab10ef
@isntlazy
refactored AddEvidence dependencies to services
c9df476
@isntlazy
refactored EditEvidence dependencies to services
4c473a0
@isntlazy
refactored Default.vue events to electron service
4f78c32
@isntlazy
continue refactoring electron parts
53e07f2
@isntlazy
continue refactoring electron parts from used components
2f5df2b
@isntlazy
continue refactoring electron parts from used components, auth, confi…
646bbc2 
…g and Setting view
@isntlazy
fixed problem with exporting session with notes
01200f7
@isntlazy
adding support to pass specific filename
93230f6
@isntlazy
refactoring electron parts in components which are in use
0cf70fa
@isntlazy
refactoring and fixing problems in settings tabs
e490c29
@isntlazy
fixing tabs to work with new structure
cb41f41
@isntlazy
fixed all settings tabs to work with a new store structure, cleaning …
bff4147 
…things
@isntlazy
refactoring ResultView
7d92bc6
dacoaster
dacoaster commented Jan 3, 2024
View reviewed changes
Copy link
Collaborator Author

@dacoaster dacoaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the help here @isntlazy ! I have left comments.

package.json Outdated Show resolved Hide resolved
src/components/ControlPanel.vue Show resolved Hide resolved
src/components/ControlPanel.vue Show resolved Hide resolved
src/components/ControlPanel.vue Outdated Show resolved Hide resolved
src/components/ControlPanel.vue Outdated Show resolved Hide resolved
src/components/MenuPopover.vue Outdated Show resolved Hide resolved
src/modules/FileSystemUtility.js Outdated Show resolved Hide resolved
src/modules/FileSystemUtility.js Outdated Show resolved Hide resolved
src/store/index.js Outdated Show resolved Hide resolved
src/store/modules/config.js Show resolved Hide resolved
@isntlazy
Copy link
Contributor

isntlazy commented Jan 3, 2024 •
edited
Loading

@dacoaster I updated PR with fixes that you suggested and resolved conflicts

@dacoaster dacoaster merged commit 2619d7d into main Jan 17, 2024
1 check failed
@dacoaster dacoaster deleted the ok/abstracting-business-logic branch January 17, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@isntlazy isntlazy isntlazy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dacoaster @isntlazy