Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang var change #138

Merged
merged 1 commit into from
Feb 22, 2024
Merged

lang var change #138

merged 1 commit into from
Feb 22, 2024

Conversation

isntlazy
Copy link
Contributor

@isntlazy isntlazy commented Feb 7, 2024

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #106

Does this introduce a breaking change?

  • Yes
  • No

@isntlazy isntlazy self-assigned this Feb 7, 2024
@isntlazy isntlazy requested a review from dacoaster as a code owner February 7, 2024 08:31
@@ -283,7 +283,7 @@
"enter_service_url": "Enter Service URL",
"confirm_delete": "Are you sure you want to delete?",
"confirm_reset": "Are you sure you want to reset?",
"confirm_reset_session": "Do you want to reset last session?",
"confirm_reset_session": "Do you want to continue your last session?",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isntlazy - Please change the var name to confirm_continue_session.

@dacoaster dacoaster merged commit 3a1f1e1 into main Feb 22, 2024
1 check failed
@dacoaster dacoaster deleted the ok/resume-session branch February 22, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants