Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Option to Add Organization Logo in PDF Generated Report #52 #146

Merged
merged 12 commits into from
Mar 27, 2024

Conversation

SmartWolf1220
Copy link

feat: Option to Add Organization Logo in PDF Generated Report #52

  • Feature.

Issue Number: #52

I have added a option to add organization logo in PDF.

@dacoaster dacoaster changed the title Ok/integration feat: Option to Add Organization Logo in PDF Generated Report #52 Mar 17, 2024
Copy link
Collaborator

@dacoaster dacoaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This lacks any way for them to choose or upload the logo, so it isn’t finished yet.

Please add the option to enable and upload a logo on the ReportsTab.vue in the settings menu.

It should have a slider toggle to enable which then allows them to access a file selector input.

This will require a new key titled “reportLogo” in the config.json and default configuration. The settings menu should update this config with the path to the file they choose.

You can then remove the checkbox from the settings panel and remove logo from the session.

@SmartWolf1220
Copy link
Author

@dacoaster . I have fixed the ui as you mentioned.
Please check and let me know.
And from now on, I will start with the new issue.

@dacoaster
Copy link
Collaborator

@dockabernathy01 - see requested changes

@SmartWolf1220
Copy link
Author

SmartWolf1220 commented Mar 21, 2024

@dacoaster , As you can see in the code, I have saved the logo to new_logo image.
So when you choose an image to use as a logo, it will be saved to new_logo image.
And I used this new_logo image in PrintView.
But If you want to change, I will change this.

@SmartWolf1220
Copy link
Author

@dacoaster , I have changed the code as you mentioned.
Please check and let me know.
Thanks.

@testfiesta testfiesta deleted a comment from SmartWolf1220 Mar 21, 2024
@SmartWolf1220
Copy link
Author

@dacoaster , I have fixed the code as you mentioned.
I have removed openImage and added v-file-input.
And I have finished feat: quicker download of report PDF #129 .
After merging this PR, I will make PR with #129 .
Thanks.

@SmartWolf1220
Copy link
Author

SmartWolf1220 commented Mar 27, 2024

@dacoaster , Can I check in your computer using Anydesk?
If you are using setTimeout to delay the execution of print function by a few seconds, I think it will work.

@dacoaster dacoaster merged commit 5f5edf5 into testfiesta:ok/integration Mar 27, 2024
@dacoaster dacoaster linked an issue Mar 27, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Option to Add Organization Logo in PDF Generated Report
2 participants