Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Id/fix os file dragging #213

Merged
merged 3 commits into from
Mar 6, 2025

Conversation

isaacdonnelson
Copy link
Contributor

Added File Path Sanitization for .png Files and Vuex Direct Mutation Fix

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The current code doesn't properly handle .png file paths with query parameters (ending with '?')

Issue Number: N/A

What is the new behavior?

  • Sanitizes .png file paths by removing trailing '?' characters before processing
  • Prevents direct mutation of Vuex state by using proper mutations
  • Creates a copy of the item object to avoid modifying the original directly
  • Maintains Electron drag functionality while improving state management

Does this introduce a breaking change?

  • Yes
  • No

This change maintains the existing functionality while improving code quality and state management, so it's not a breaking change.

Does this introduce UI changes? If so, have they been tested on both dark and light modes?

  • Yes
  • No

This is a backend logic change and doesn't affect the UI directly.

@dacoaster dacoaster merged commit abec230 into testfiesta:main Mar 6, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants