Prepare tests for upcoming twisted version #387
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current twisted trunk (twisted/twisted@49a649b) breaks two tests in the
twistedsupport
test suite, see the error log below. I was able to bisect the braking commit twisted/twisted@1269e56 introduced in PR twisted/twisted#12207. ThemainLoop
newly logsMain loop terminated.
message even on exception, see twisted/twisted@1269e56#diff-c6cc886d2bcab963daa7b561a036e0bea05ef01ef3351f66489f1fffea94c1eaR702-R710 but both affected tests expect onlyfoo
.This hackish PR tries to address the upcoming issue.