Skip to content

Conversation

@mlz11
Copy link
Contributor

@mlz11 mlz11 commented Aug 13, 2024

Fixes #483

This PR adds support for InputSignalWithTransform in the inputs property added by #473.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mlz11 , I left a few comments.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@timdeschryver timdeschryver merged commit 9160da1 into testing-library:main Aug 13, 2024
@timdeschryver
Copy link
Member

@all-contributors please add @mlz11 for code, tests

@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @mlz11! 🎉

@zargham-k
Copy link

this PR breaks angular 17 application build

@zargham-k
Copy link

zargham-k commented Sep 24, 2024

we need to either update version compatibility docs or make it v17 compatible to angular v17 @timdeschryver @mlz11

@timdeschryver
Copy link
Member

Please create a new issue for this @zargham-leanix
In the issue please mention the versions (Angular, Testing Library) that are used.
I tried to reproduce this but wasn't able to reproduce it, so a reproduction will speed up the process to get this resolved.
Feel free to also create a PR with a fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression on components with inputs using a transform function

3 participants