-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Internalize type definitions #145
Comments
I am happy to pick this up. |
This one is in progress. I am encountering some issues with conflicting type definitions but it's getting there. |
I haven't been able to figure this out and I am kind of stuck now :-/ I am quoting my message on Discord about the issue
Is it worth opening a PR with what I have so far? |
Yes, please skip the hook if it's preventing you from opening your PR. |
It would help with issues like #121 and in general I don't think there's a lot of value having them externalized to DefinitelyTyped (https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/testing-library__cypress). Let's bring them in.
Anyone wanna work on this?
The text was updated successfully, but these errors were encountered: