Add forward compatibility with Cypress 10 #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any suggestions how to write Tests for this change? Or is dev/manual testing enough? |
NicholasBoll
approved these changes
Nov 15, 2022
|
I'm good with manual testing. I've manually verified there are no more warnings in the log. |
3 tasks
|
🎉 This PR is included in version 8.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding forward compatibility with Cypress 10 which now deprecated
cy.state('subject')usage and directs developersto use cy.currentSubject() instead.
Cypress changelog mentioning above: https://docs.cypress.io/guides/references/changelog#10-5-0
Without those changes, Cypress 10 spams dev tools console log with hundreds of warnings about usage of deprecated cy.state('subject'). Makes debugging harder then it should be.
How:
Checking for existence of new currentSubject method in cy object and using it instead when present.
Checklist: