Skip to content

Commit

Permalink
feat: Reduce caught exceptions in prettyDom (reland) (#1323)
Browse files Browse the repository at this point in the history
Co-authored-by: David Rieman <DavidRieman@users.noreply.github.com>
Co-authored-by: David Rieman <david.rieman@wbd.com>
  • Loading branch information
3 people authored Jul 22, 2024
1 parent 33555a3 commit a86c54c
Showing 1 changed file with 12 additions and 8 deletions.
20 changes: 12 additions & 8 deletions src/pretty-dom.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,19 @@ import {getDocument} from './helpers'
import {getConfig} from './config'

const shouldHighlight = () => {
if (typeof process === 'undefined') {
// Don't colorize in non-node environments (e.g. Browsers)
return false
}
let colors
// Try to safely parse env COLORS: We will default behavior if any step fails.
try {
colors = JSON.parse(process?.env?.COLORS)
} catch (e) {
// If this throws, process?.env?.COLORS wasn't parsable. Since we only
const colorsJSON = process.env?.COLORS
if (colorsJSON) {
colors = JSON.parse(colorsJSON)
}
} catch {
// If this throws, process.env?.COLORS wasn't parsable. Since we only
// care about `true` or `false`, we can safely ignore the error.
}

Expand All @@ -18,11 +26,7 @@ const shouldHighlight = () => {
return colors
} else {
// If `colors` is not set, colorize if we're in node.
return (
typeof process !== 'undefined' &&
process.versions !== undefined &&
process.versions.node !== undefined
)
return process.versions !== undefined && process.versions.node !== undefined
}
}

Expand Down

0 comments on commit a86c54c

Please sign in to comment.