-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use defineProperty on the error object instead of setting the message… #1261
Use defineProperty on the error object instead of setting the message… #1261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me.
It's not breaking, but we can take add this to the aplha
branch and release it with the next major version.
Thanks for the review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a0e916f:
|
Codecov Report
@@ Coverage Diff @@
## main #1261 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 24 24
Lines 1038 1038
Branches 351 351
=========================================
Hits 1038 1038
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@all-contributors please add @julienw for code, bug |
I've put up a pull request to add @julienw! 🎉 |
… directly
Fixes #1259
What: Use defineProperty on the error object instead of setting the message directly (Fixes #1259)
Why: With a DOMException, the error isn't propagated properly without this fix.
How: I used defineProperty instead of setting the message property directly.
Checklist:
Documentation added to the docs siteunneededTypeScript definitions updatedunneeded