Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Pin NPM version #1262

Merged
merged 4 commits into from
Sep 17, 2023
Merged

chore: Pin NPM version #1262

merged 4 commits into from
Sep 17, 2023

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Sep 16, 2023

Closes #1242

overrides is not available in NPM bundled with Node.js 14. But we can hopefully use later NPM versions in older Node.js version.

That way we can keep CI alive without having to make breaking changes.

@eps1lon eps1lon marked this pull request as draft September 16, 2023 08:57
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b8b1ca5:

Sandbox Source
react-testing-library-examples Configuration
react-testing-library demo Issue #1242

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #1262 (b8b1ca5) into main (336152b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1262   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           24        24           
  Lines         1038      1038           
  Branches       349       351    +2     
=========================================
  Hits          1038      1038           
Flag Coverage Δ
node-14 100.00% <ø> (?)
node-16 100.00% <ø> (ø)
node-18 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eps1lon eps1lon marked this pull request as ready for review September 16, 2023 09:26
Copy link
Member

@MatanBobi MatanBobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't thought of this idea.
That's a good change to unblock ci.
Thanks :)

@eps1lon eps1lon merged commit 07f5999 into testing-library:main Sep 17, 2023
6 checks passed
@eps1lon eps1lon deleted the chore/pin-npm branch September 17, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI failing with op_mob browserslist error
2 participants